Skip to content

fix(cli): dedupe /model user providers and filter irrelevant doctor w… - #15029

Closed
dptomadera-dotcom wants to merge 1 commit into
NousResearch:mainfrom
dptomadera-dotcom:main
Closed

fix(cli): dedupe /model user providers and filter irrelevant doctor w…#15029
dptomadera-dotcom wants to merge 1 commit into
NousResearch:mainfrom
dptomadera-dotcom:main

Conversation

@dptomadera-dotcom

Copy link
Copy Markdown

…arnings

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 24, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Closing — the hermes doctor validation fix for user-defined providers: entries landed via salvage #15083 (of parallel #14857), which routes through resolve_provider_full() in both doctor.py and select_provider_and_model().

Your dedupe-/model-rows fix addresses a different issue (duplicate rows in the picker when the same provider is both built-in and user-configured). That's worth a separate PR scoped only to the dedupe logic — happy to review if you want to open one.

@teknium1 teknium1 closed this Apr 24, 2026
@dptomadera-dotcom

Copy link
Copy Markdown
Author

LGTM.

He revisado la PR localmente y validé los tests relevantes con:
scripts/run_tests.sh tests/hermes_cli/test_doctor.py tests/hermes_cli/test_user_providers_model_switch.py

Resultado:

  • 39 passed
  • 0 failed

Lo que veo bien:

  • hermes doctor deja de mostrar ruido por toolsets no aplicables o deshabilitados, respetando la configuración efectiva de plataforma.
  • Se elimina el warning genérico de GITHUB_TOKEN, lo que mejora la señal del diagnóstico.
  • El fix de /model corrige el caso real de duplicados cuando providers: usa un nombre amigable y custom_providers: usa el slug para el mismo endpoint.
  • La cobertura añadida encaja bien con los cambios y protege ambos comportamientos.

Riesgos / notas:

  • No veo nada bloqueante.
  • El área más sensible es el filtrado de toolsets en doctor, porque depende de la resolución de herramientas por plataforma; por suerte queda cubierto con tests.

En conjunto, me parece una mejora clara de UX sin regresiones aparentes. Aprobaría.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants