fix(update): honor protected local workflows - #14998
Closed
stefanpieter wants to merge 1 commit into
Closed
stefanpieter wants to merge 1 commit into
stefanpieter wants to merge 1 commit into
Conversation
This was referenced Apr 24, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in protected local update workflow guard for source checkouts that intentionally carry local commits or tracked customizations on top of upstream Hermes, such as customized dashboard installs.
When configured via environment variables, Hermes now:
recommended_update_command()instead of telling users to run rawhermes update;hermes updatebefore the stock update/autostash path runs;hermes updatepath.This addresses the dashboard/customization persistence class of failures discussed in #3523 and the update-command UX concern in #6357.
Configuration
Opt-in environment variables:
HERMES_PROTECTED_UPDATE_COMMAND: command to show/run for the protected update workflow.HERMES_PROTECTED_UPDATE_BRANCH: optional local branch name to verify and display.HERMES_PROTECTED_UPDATE_HELPER: optional helper script path; if no command is configured, Hermes builds apython3 <helper> --repo <repo> --branch <branch>command.HERMES_PROTECTED_UPDATE_REBASE_COMMAND: optional manual rebase/helper command shown in the block message.HERMES_ALLOW_PROTECTED_BRANCH_UPDATE=1: explicit escape hatch to bypass the guard.Validation
git diff --check --cachedpython -m py_compile hermes_cli/config.py hermes_cli/main.py tests/hermes_cli/test_managed_installs.pypython -m pytest tests/hermes_cli/test_managed_installs.py -q -o 'addopts='→13 passedshleximport/test gap and branch-verification fail-open risk