Refactor: implement centralized HERMES_HOME environment variable support (#892) - #1489
Closed
Nebula037 wants to merge 2 commits into
Closed
Refactor: implement centralized HERMES_HOME environment variable support (#892)#1489Nebula037 wants to merge 2 commits into
Nebula037 wants to merge 2 commits into
Conversation
…#892) Introduces get_hermes_home() to allow overriding the default ~/.hermes directory via HERMES_HOME environment variable.
…usResearch#892) Replaced localized get_hermes_home() call with the centralized HERMES_HOME constant from hermes_constants. This ensures consistent directory resolution across the entire toolkit.
Contributor
|
Closing — the issue this targets (#892) is already fully resolved. All 9 files listed in the issue already import This PR would introduce a second |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR centralizes the resolution of the agent's base directory by introducing a global
HERMES_HOMEconstant. It enables users to override the default~/.hermespath using theHERMES_HOMEenvironment variable, which is critical for containerized deployments (Docker/Podman), CI/CD pipelines, and multi-instance management.Related Issue
Fixes #892
Type of Change
Changes Made
get_hermes_home()utility and exportedHERMES_HOMEas apathlib.Pathobject.HERMES_HOMEfrom constants, replacing the localized path resolution for theprocesses.jsoncheckpoint file.How to Test
~/.hermes.export HERMES_HOME=/tmp/hermes_testand start the agent.processes.jsonis created in/tmp/hermes_test/instead of the home directory.Checklist
Code
pytest tests/ -qand all tests pass (N/A for browser-only refactor, relying on CI)Documentation & Housekeeping
pathlib