fix(agent): handle aws_sdk auth type in resolve_provider_client by Tranquil-Flow · Pull Request #14770 · NousResearch/hermes-agent

Tranquil-Flow · 2026-04-23T22:22:21Z

What does this PR do?

Adds the missing aws_sdk auth type branch in resolve_provider_client(). Before this fix, Bedrock's aws_sdk auth type fell through to the "unhandled auth_type" warning and returned (None, None), silently breaking all auxiliary tasks (compression, memory, summarization) for every Bedrock user. The main conversation loop worked fine, but background context management failed.

The fix creates an AnthropicAuxiliaryClient via build_anthropic_bedrock_client(), using boto3's default credential chain (IAM roles, SSO, env vars, instance metadata). Default auxiliary model is anthropic.claude-haiku-4-5-20251001-v1:0 for cost efficiency.

Related Issue

Fixes #13919

Type of Change

🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

agent/auxiliary_client.py: Added elif pconfig.auth_type == "aws_sdk": branch in resolve_provider_client() that resolves AWS credentials, creates an AnthropicAuxiliaryClient wrapper, and handles both sync and async modes
tests/agent/test_bedrock_integration.py: Added TestAuxiliaryClientBedrockResolution class with 6 tests covering credentials present/absent, region configuration, explicit model override, async mode, and default model selection

How to Test

python -m pytest -o 'addopts=' tests/agent/test_bedrock_integration.py::TestAuxiliaryClientBedrockResolution -v

Result: 6 passed. Full Bedrock integration suite: 46 passed.

Checklist

Code

I've read the Contributing Guide
My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
I searched for existing PRs to make sure this isn't a duplicate
My PR contains only changes related to this fix/feature (no unrelated commits)
I've run pytest tests/ -q and all tests pass
I've added tests for my changes (required for bug fixes, strongly encouraged for features)
I've tested on my platform: macOS 15 (Darwin 24.6.0), Python 3.14.2

Documentation & Housekeeping

I've updated relevant documentation (README, docs/, docstrings) — or N/A
I've updated cli-config.yaml.example if I added/changed config keys — or N/A
I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Bedrock's aws_sdk auth_type had no matching branch in resolve_provider_client(), causing it to fall through to the "unhandled auth_type" warning and return (None, None). This broke all auxiliary tasks (compression, memory, summarization) for Bedrock users — the main conversation loop worked fine, but background context management silently failed. Add an aws_sdk branch that creates an AnthropicAuxiliaryClient via build_anthropic_bedrock_client(), using boto3's default credential chain (IAM roles, SSO, env vars, instance metadata). Default auxiliary model is Haiku for cost efficiency. Closes NousResearch#13919

alt-glitch · 2026-04-23T22:28:37Z

Prior PRs #11612 and #12365 address the same issue #13919. This is the latest attempt.

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of #14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by #14664, and the aux client aws_sdk branch was subsumed by #14770 (both in the same salvage PR as this commit).

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

teknium1 · 2026-04-27T04:52:50Z

Thanks for this contribution, @Tranquil-Flow! This fix has already landed on main.

Automated hermes-sweeper review found:

The elif pconfig.auth_type == "aws_sdk": branch is present in agent/auxiliary_client.py at line 2039, implementing exactly what this PR describes (boto3 credential chain, build_anthropic_bedrock_client, AnthropicAuxiliaryClient construction, async mode support).
Commit 7dc6eb9fb on main carries the identical message: fix(agent): handle aws_sdk auth type in resolve_provider_client — this appears to be a squash-salvage of this or one of the prior attempts (fix(bedrock): route auxiliary tasks through AnthropicBedrock SDK #11612, [Bug]: auxiliary_client が Bedrock (aws_sdk) 認証に未対応 — context compression / summarization が動作しない #13919, feat: add AWS Bedrock support for auxiliary LLM tasks #12365) noted by @alt-glitch.

Closing as implemented on main. The fix to issue #13919 is shipped. 🎉

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

@bsgdigital

…rupt Three interrupt-recovery sites in run_agent.py rebuilt self._anthropic_client with build_anthropic_client(self._anthropic_api_key, ...) unconditionally. When provider=bedrock + api_mode=anthropic_messages (AnthropicBedrock SDK path), self._anthropic_api_key is the sentinel 'aws-sdk' — build_anthropic_client doesn't accept that and the rebuild either crashed or produced a non-functional client. Extract a _rebuild_anthropic_client() helper that dispatches to build_anthropic_bedrock_client(region) when provider='bedrock', falling back to build_anthropic_client() for native Anthropic and other anthropic_messages providers (MiniMax, Kimi, Alibaba, etc.). Three inline rebuild sites now call the helper. Partial salvage of NousResearch#14680 by @bsgdigital — only the _rebuild_anthropic_client helper. The normalize_model_name Bedrock-prefix piece was subsumed by NousResearch#14664, and the aux client aws_sdk branch was subsumed by NousResearch#14770 (both in the same salvage PR as this commit).

alt-glitch added type/bug Something isn't working P1 High — major feature broken, no workaround comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/bedrock AWS Bedrock (boto3, IAM) labels Apr 23, 2026

teknium1 mentioned this pull request Apr 24, 2026

fix(bedrock): consolidated — model-ID detection, context length priority, aux aws_sdk, stale-connection eviction, interrupt rebuild #15184

Merged

teknium1 mentioned this pull request Apr 24, 2026

[Feature] Support AWS Bedrock as auxiliary LLM provider (compression / vision / summarization) #11946

Closed

teknium1 mentioned this pull request Apr 27, 2026

fix(bedrock): inference profile ID preservation + correct client rebuild on interrupt #14680

Closed

2 tasks

teknium1 closed this Apr 27, 2026

Navigation Menu

Uh oh!

fix(agent): handle aws_sdk auth type in resolve_provider_client - #14770

fix(agent): handle aws_sdk auth type in resolve_provider_client#14770
Tranquil-Flow wants to merge 1 commit into
NousResearch:mainfrom
Tranquil-Flow:fix/auxiliary-bedrock-aws-sdk-auth

Tranquil-Flow commented Apr 23, 2026

Uh oh!

alt-glitch commented Apr 23, 2026

Uh oh!

teknium1 commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Tranquil-Flow commented Apr 23, 2026

What does this PR do?

Related Issue

Type of Change

Changes Made

How to Test

Checklist

Code

Documentation & Housekeeping

Uh oh!

alt-glitch commented Apr 23, 2026

Uh oh!

teknium1 commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants