Skip to content

fix(moa): replace deprecated gemini-3-pro-preview + forward max_tokens - #14764

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-2f58d50c
Apr 23, 2026
Merged

fix(moa): replace deprecated gemini-3-pro-preview + forward max_tokens#14764
teknium1 merged 2 commits into
mainfrom
hermes/hermes-2f58d50c

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #6636 (@devorun) onto current main.

Summary

Stops MoA from 404-looping on OpenRouter after google/gemini-3-pro-preview was pulled upstream, and forwards max_tokens on both reference and aggregator calls (was missing — the API silently accepted the param-less request but user-set limits were ignored).

Reported via Norbert's Discord cron failure (paste.rs/Q5WEB): 6 retries × 4 frontier models × 600s idle timeout = one dead cron job + $4.63 burned.

Changes

  • tools/mixture_of_agents_tool.py: google/gemini-3-pro-previewgoogle/gemini-2.5-pro; add max_tokens to both chat.completions.create() calls
  • tests/tools/test_mixture_of_agents_tool.py: convert the catalog-snapshot test to an invariant (non-empty, well-formed vendor/model slugs) — the old test was a change-detector that would flip red on the next churn anyway
  • scripts/release.py: AUTHOR_MAP entry for @devorun

Validation

tests/tools/test_mixture_of_agents_tool.py .................. 3 passed

Does NOT fix the bigger cost problem (MoA still calls 3+ frontier models when the agent decides to use it, and cron currently ignores hermes tools config so users can't disable it there). Those are separate follow-ups — next PR wires cron to _get_platform_tools() so hermes tools actually gates cron toolsets.

Closes #6636.

devorun and others added 2 commits April 23, 2026 15:13
…ariant

- AUTHOR_MAP entry for 130918800+devorun for #6636 attribution
- test_moa_defaults: was a change-detector tied to the exact frontier
  model list — flips red every OpenRouter churn. Rewritten as an
  invariant (non-empty, valid vendor/model slugs).
@teknium1
teknium1 force-pushed the hermes/hermes-2f58d50c branch from 6991f1b to b257925 Compare April 23, 2026 22:14
@teknium1
teknium1 merged commit 5e67b38 into main Apr 23, 2026
10 of 11 checks passed
@teknium1
teknium1 deleted the hermes/hermes-2f58d50c branch April 23, 2026 22:14
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tools Tool registry, model_tools, toolsets labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants