fix(honcho): honor host-specific baseUrl - #14489
Conversation
|
Thanks for the focused regression test. Current Problems
Suggested changes
Automated hermes-sweeper review. |
|
Drive-by data point from someone who hit this independently and landed on the identical patch before finding this PR. Not asking for a merge — just adding four facts the review above didn't have, because I think one of them undercuts its central premise. The review's reasoning is that 1. 2. The test that asserted the contract is gone. The review cites 3. That test's own rationale has expired. Its docstring justified root-only as "consistent with 4. The plugin README states the opposite rule. On the review's substantive point — that changing this properly means touching setup and docs too — I think that's right, and worth separating from the reader change. The setup flow does write The practical case, for whatever it's worth: one machine, several profiles, a self-hosted Honcho on the LAN for one of them and the default for the rest. Every other setting needed for that already honours the host block. Happy to leave this as evidence on your PR rather than open a competing one — and if a maintainer does elect the per-host direction, I'm glad to do the setup + schema + docs half as a separate change so this one can stay small. |
Summary
hosts.<name>.baseUrlwhen resolving Honcho client configTesting
python3 -m pytest -o addopts='' tests/honcho_plugin/test_client.py -qIssue