fix: add document extensions to MEDIA: path extraction regex - #14436
Closed
johnchen86 wants to merge 1 commit into
Closed
fix: add document extensions to MEDIA: path extraction regex#14436johnchen86 wants to merge 1 commit into
johnchen86 wants to merge 1 commit into
Conversation
Extract MEDIA: tags with common document extensions (xlsx, docx, pdf, pptx, txt, csv, json, xml, zip, rar, 7z) in addition to existing image/video/audio extensions. Fixes file paths with document extensions being truncated during send.
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #14307 (merged) — same regex extension for document extensions in MEDIA: tag extraction. This may already be on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
BasePlatformAdapter.extract_media()to correctly extractMEDIA:tags containing document file paths (xlsx, docx, pdf, pptx, etc.).Problem
The regex pattern only matched image/video/audio extensions, causing document paths to be truncated during extraction.
Solution
Extend the media pattern regex to include common document extensions: xlsx?, docx?, pdf, pptx, txt, csv, json, xml, zip, rar, 7z.
Testing
Verified that extract_media() now correctly extracts full document paths, and confirmed successful WeChat file delivery of xlsx files.