fix(gateway): remove stale default pid file on startup - #14298
Closed
jackylai2660707 wants to merge 1 commit into
Closed
fix(gateway): remove stale default pid file on startup#14298jackylai2660707 wants to merge 1 commit into
jackylai2660707 wants to merge 1 commit into
Conversation
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway.pidfiles directly when startup detects an invalid/dead PIDProblem
When a gateway self-restart or
--replacehandoff leaves behind a stale defaultgateway.pid,get_running_pid()correctly detects that the PID is dead but_cleanup_invalid_pid_path()routes cleanup throughremove_pid_file(). That helper only removes pid files owned by the current process, so the stale pid file survives and subsequent startups keep failing withPID file race lost to another gateway instance.Testing
/root/.hermes/hermes-agent/venv/bin/pytest tests/gateway/test_status.py -q