You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-verified against current origin/main (27c486e3b): this appears resolved. plugins/memory/honcho/client.py already sanitizes gateway session keys (re.sub(r'[^a-zA-Z0-9_-]+', '-', ...)) and bounds them via _enforce_session_id_limit against _HONCHO_SESSION_ID_MAX_LEN = 100, truncating over-limit keys to a sanitized prefix plus a sha256 hash suffix so distinct long ids don't collide. That's the same bound-and-sanitize this PR set out to add.
Recommend closing as superseded — happy to be corrected if I've misread the current state.
Thanks for the focused Honcho regression fix. This automated hermes-sweeper review found that the requested behavior is already on current main.
plugins/memory/honcho/client.py:648 bounds sanitized session IDs to 100 characters and appends a deterministic SHA-256 suffix; resolve_session_name() applies it to gateway_session_key at :699-701.
tests/honcho_plugin/test_client.py:745 already covers long Matrix-style keys, determinism, allowed characters, and non-collision for shared prefixes.
The equivalent fix shipped in cd1c4812abe8731dc485f15da14412c1f9e6f60e (fix(honcho): truncate resolve_session_name output to Honcho's 100-char limit (#13868)), included in v2026.4.30.
This also confirms the June 26 re-verification comment that the PR is superseded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway_session_keyvalues through a deterministic Honcho session-id helperTesting
Closes #13868