Skip to content

fix(cli): normalize saved platform tool entries - #14101

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/platform-tools-no-mcp-normalization-13028
Closed

fix(cli): normalize saved platform tool entries#14101
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/platform-tools-no-mcp-normalization-13028

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • normalize saved platform tool entries to strings before preserving and sorting them
  • drop a stale no_mcp sentinel when the new selection explicitly re-enables MCP server entries
  • add regressions for the stale sentinel and numeric YAML-name save paths

Testing

Fixes #13028

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets labels Apr 22, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #13086 — same fix for stale no_mcp sentinel and numeric toolset name normalization (#13028).

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the PR, @LeonSGP43! Both fixes here are already on main.

This is an automated hermes-sweeper review.

Both fixes are confirmed present in the current main branch. Closing as implemented.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: _save_platform_tools preserves stale no_mcp and still crashes on numeric entries

3 participants