fix(skins): per-skin status bar color overrides (salvage #1866) - #14015
Merged
Conversation
Route prompt_toolkit status bar colors through the skin engine so /skin updates the status bar alongside the rest of the interactive TUI. Add regression coverage for the new status bar style override keys and CLI style composition.
Drop rebased test assumptions about theme-mode helpers removed on main and keep the status bar skin integration aligned with the current skin engine model.
The salvaged status-bar skin keys were seeded on the default skin, but
_build_skin_config merges default.colors into every skin — so daylight
and warm-lightmode silently inherited silver status_bar_text (#C0C0C0)
on their light backgrounds, rendering as low-contrast gray on gray.
Drop the seven status_bar_{text,strong,dim,good,warn,bad,critical}
entries from the default skin's colors and let get_prompt_toolkit_style
_overrides fall back to banner_text / banner_title / banner_dim /
ui_ok / ui_warn / ui_error. Dark skins keep their explicit overrides
and render identically; light skins now inherit their own dark banner
colors for readable status-bar text.
alt-glitch
added
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skins can now customize the CLI status bar palette independently of their banner palette via eight new color keys:
status_bar_bg,status_bar_text,status_bar_strong,status_bar_dim,status_bar_good,status_bar_warn,status_bar_bad,status_bar_critical. Skins that don't set them keep current behavior (status bar falls back to banner_text/banner_title/banner_dim/ui_ok/ui_warn/ui_error).Salvages #1866 (@kshitijk4poor) onto current main.
Changes
hermes_cli/skin_engine.py: per-skinstatus_bar_*blocks for ares, dragonflame (charizard), ghost (sisyphus), midnight (slate), nous (default), silver (mono), sunrise (poseidon); resolver reads new keys inget_prompt_toolkit_style_overrides().status_bar_{text,strong,dim,good,warn,bad,critical}seeds from thedefaultskin so_build_skin_configdoesn't inherit silver text into light-mode skins (daylight, warm-lightmode). Dark skins render identically; light skins now use their ownbanner_text/etc. for readable contrast.tests/hermes_cli/test_skin_engine.pyandtests/test_cli_skin_integration.py.Validation
scripts/run_tests.sh tests/hermes_cli/test_skin_engine.py tests/test_cli_skin_integration.pyCloses #1866.