fix: harden ClawHub skill search exact matches - #1400
Merged
Conversation
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…45b79a59-clawhub-search fix: harden ClawHub skill search exact matches
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…45b79a59-clawhub-search fix: harden ClawHub skill search exact matches
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…45b79a59-clawhub-search fix: harden ClawHub skill search exact matches
dizhaky
pushed a commit
to dizhaky/hermes-agent
that referenced
this pull request
Aug 1, 2026
…through CodeQL alert NousResearch#1400 flagged the refusal warning at line 113: even though the logged value was a canonical constant from the static blocklist, it was returned by _is_hermes_provider_credential, whose name matches CodeQL's sensitive-data heuristic, so its return value is treated as secret-tainted. - _is_hermes_provider_credential reverted to a bool predicate; nothing it returns is ever logged. - Refusals are aggregated and logged as a count with a static message. - _load_config_passthrough no longer logs str(exc) (YAML parse errors can quote config lines that may contain secrets); logs the exception type name only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014quAJiFx19py9nV6NnsnHr
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…45b79a59-clawhub-search fix: harden ClawHub skill search exact matches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillpayloads from the ClawHub detail endpoint so direct inspect fallback returns real metadataWhy
hermes skills search self-improving-agent --source clawhubwas reaching ClawHub, but the ClawHub search endpoint was returning unrelated skills for that exact query. The skill was still directly accessible at/api/v1/skills/self-improving-agent, so Hermes needed a stricter exact-match fallback instead of trusting the noisy search response.Validation
Working locally after the fix:
python -m hermes_cli.main skills search self-improving-agent --source clawhubself-improving-agentas the exact ClawHub hitTests run:
python -m pytest tests/tools/test_skills_hub_clawhub.py tests/tools/test_skills_hub.py tests/hermes_cli/test_skills_hub.py -n0 -qpython -m pytest tests/ -n0 -qNote on full suite:
tests/test_api_key_providers.py::TestResolveProvider::test_auto_detects_minimax_cn_keytests/test_openai_client_lifecycle.py::test_concurrent_requests_do_not_break_each_other_when_one_client_closes