fix(cli): deduplicate plugin toolsets against built-in keys in hermes tools (Closes #13640) - #13804
Closed
ms-alan wants to merge 2 commits into
Closed
fix(cli): deduplicate plugin toolsets against built-in keys in hermes tools (Closes #13640)#13804ms-alan wants to merge 2 commits into
ms-alan wants to merge 2 commits into
Conversation
Contributor
|
Thanks for this fix! The toolset deduplication you proposed in This is an automated hermes-sweeper review.
Note: this PR also touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a plugin registers a tool into an existing built-in toolset (e.g.
toolset="web"),hermes toolsshowed duplicate rows for the same toolset key. The built-in row and plugin-derived row both appeared, even though they mapped to the same underlyingwebkey.Fix: In
_get_effective_configurable_toolsets(), skip plugin toolsets whose key already exists inCONFIGURABLE_TOOLSETS. Plugin-added tools now extend the existing toolset instead of creating a second top-level row.Changes
hermes_cli/tools_config.py: Filter plugin toolsets against built-in keys before appendingTesting
Install a plugin that registers a tool with
toolset="web"→hermes toolsnow shows only onewebrow (not two)Closes #13640