fix(delegate): add timeout to subagent run_conversation() (Closes #13768) - #13797
Closed
ms-alan wants to merge 2 commits into
Closed
fix(delegate): add timeout to subagent run_conversation() (Closes #13768)#13797ms-alan wants to merge 2 commits into
ms-alan wants to merge 2 commits into
Conversation
added 2 commits
April 22, 2026 10:58
…Research#13720) When a long-running task is interrupted, prompt_toolkit flushes stdout. If stdout is in a broken state (pipe closed, /dev/null), this raises OSError with errno.EIO. The existing except (KeyError, OSError) block only handled 'is not registered' / 'Bad file descriptor' strings. Add errno.EIO check so EIO errors are silently suppressed instead of crashing the CLI. Import errno at top of cli.py.
alt-glitch
added
type/bug
Collaborator
Collaborator
|
May be superseded by #13770 (merged). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
child.run_conversation() in _run_single_child was a raw blocking call — if the subagent got stuck on a slow API or network issue, the parent agent would hang indefinitely.
Fix: Run run_conversation in a dedicated thread with join(timeout=300). On timeout, call child.interrupt() for graceful shutdown, then set a synthetic timeout result.
Changes
Testing
Simulate a stuck subagent (e.g. mock API delay > timeout) → parent returns error instead of hanging
Closes #13768