Repository navigation
fix(slack): honor Agent Sessions status lifecycle - #137393
Closed
yeshymanoharan wants to merge 1 commit into
Closed
yeshymanoharan wants to merge 1 commit into
yeshymanoharan wants to merge 1 commit into
Conversation
yeshymanoharan
force-pushed
the
fix/slack-agent-session-status-contract
branch
from
October 12, 2026 20:40
84a4696 to
1415983
Compare
Author
|
Closing after reviewing the existing issue and active implementation discussion more closely. I will coordinate with the existing fix cluster rather than add another competing carrier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Slack's missing working indicator after the Agent Sessions migration.
agents.sessions.setStatusaccepts lifecycle values—not free text—so the adapter now sendsprocessingfor a non-empty working state andactivewhen clearing. A concrete client that falls back to legacyassistant.threads.setStatusstill receives its original free text and empty clear.Slack contract:
agents.sessions.setStatus, loading-state guidance, and compatibility bridge.Related Issue
Fixes #110374
Type of Change
Changes Made
processing/active.How to Test
scripts/run_tests.sh tests/gateway/test_slack.py tests/gateway/test_slack_agent_sessions_status_fallback.py— 216 passed, 1 skipped.scripts/run-in-hermes-env python scripts/check— 12 checks passed; 0 health findings.git diff --checkChecklist
Code
main, minimal carrier for the existing fix clusterpython scripts/checkpassesDocumentation & Housekeeping
CONTRIBUTING.md/AGENTS.mdN/A — no workflow changesScreenshots / Logs
N/A — verified with mocked Slack clients and the repository test suite.