Skip to content

fix(tui): /resume picker shows telegram/discord/etc sessions - #13724

Merged
OutThisLife merged 2 commits into
mainfrom
bb/tui-resume-all-sources
Apr 21, 2026
Merged

fix(tui): /resume picker shows telegram/discord/etc sessions#13724
OutThisLife merged 2 commits into
mainfrom
bb/tui-resume-all-sources

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • session.list only fetched source=\"tui\" + source=\"cli\" rows and sorted them
  • Users could already hermes --tui --resume <telegram-session-id> via paste, but the /resume modal never surfaced those rows
  • Drop the filter: list_sessions_rich(source=None) returns every adapter, child sessions (subagents/compression) stay hidden via the hermes_state default

Issue

Row 7 from the TUI v2 blitz Confluence: "when using the /resume modal inside an instance, only tui and cli sessions are displayed".

Test plan

  • pytest tests/gateway/test_session_list_all_sources.py — 3 passing
  • Manual: hermes --tui, run /resume, verify telegram/discord rows appear alongside tui/cli

Reported during TUI v2 blitz retest: /resume modal only surfaced tui/cli
rows, even though `hermes --tui --resume <id>` with a pasted telegram
session id works fine.  The handler double-fetched with explicit
`source="tui"` and `source="cli"` filters and dropped everything else on
the floor.

Drop the filter — list_sessions_rich(source=None) already excludes
child sessions (subagents, compression continuations) via its default,
and users want to resume messenger sessions from inside the TUI.

Adds gateway regression coverage.
@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels Apr 21, 2026
Follow-up on #13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row #7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
@OutThisLife
OutThisLife merged commit 90fca3c into main Apr 21, 2026
11 of 12 checks passed
@OutThisLife
OutThisLife deleted the bb/tui-resume-all-sources branch April 21, 2026 23:59
aj-nt pushed a commit to aj-nt/hermes-agent that referenced this pull request May 1, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row #7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
aj-nt pushed a commit to aj-nt/hermes-agent that referenced this pull request May 1, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row NousResearch#7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row NousResearch#7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row NousResearch#7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row NousResearch#7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
Follow-up on NousResearch#13724: showing literally every source was too noisy.\n\n now fetches a wider window (, larger limit) and then filters to a curated allowlist of human-facing sources (tui/cli plus chat adapters like telegram/discord/slack/whatsapp/etc). This keeps row NousResearch#7 fixed (telegram sessions visible in /resume) without surfacing internal source kinds such as tool/acp.
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
…-all-sources

fix(tui): /resume picker shows telegram/discord/etc sessions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants