Skip to content

fix: self-heal stale gateway runtime state on launchd start/stop - #13717

Closed
Tess-SourceOne wants to merge 1 commit into
NousResearch:mainfrom
Tess-SourceOne:fix/gateway-launchd-stale-runtime-state
Closed

fix: self-heal stale gateway runtime state on launchd start/stop#13717
Tess-SourceOne wants to merge 1 commit into
NousResearch:mainfrom
Tess-SourceOne:fix/gateway-launchd-stale-runtime-state

Conversation

@Tess-SourceOne

Copy link
Copy Markdown

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 21, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related: #13560 and #13553 also harden macOS launchd recovery — check for overlap.

1 similar comment
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related: #13560 and #13553 also harden macOS launchd recovery — check for overlap.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by #14200.

Triage notes (medium confidence):
Merged PR #14200 ('fix(gateway): recover stale pid and planned restart state') reworked _cleanup_invalid_pid_path and stale runtime recovery in gateway/status.py + hermes_cli/gateway.py covering the same self-heal-on-launchd-start scenario.

Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen.

(Bulk-closed during a CLI PR triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants