fix(encoding): add UTF-8 encoding for Windows compatibility (#7537, #8901, #7058) - #13593
Closed
zhanggttry wants to merge 3 commits into
Closed
zhanggttry wants to merge 3 commits into
zhanggttry wants to merge 3 commits into
Conversation
…arch#7537, NousResearch#8901, NousResearch#7058) - doctor.py: replace emoji with ASCII to avoid GBK encoding errors - claw.py: add encoding='utf-8' and errors='replace' to subprocess calls - cli.py: add encoding='utf-8' to config file open()
3 tasks
Contributor
Contributor
Author
|
Closing in favor of #13986 which already includes UTF-8 encoding fixes across all files. This PR also contained unrelated changes (concurrent.futures, account_usage, base_url_host_matches) that triggered Supply Chain Audit failures. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows users encounter encoding errors when Hermes tries to:
Solution
[Hermes Doctor]to avoid GBK encoding errors on Windowsencoding="utf-8"anderrors="replace"to allsubprocess.run()calls for Windows compatibilityencoding="utf-8"to config fileopen()callChanges
hermes_cli/doctor.pyhermes_cli/claw.pycli.pyTesting
hermes doctorshould not crash with UnicodeEncodeErrorhermes claw migratesubprocess calls should handle non-UTF8 outputRelated Issues