fix(honcho): support base_url-only config in cmd_identity for local instances - #13439
fix(honcho): support base_url-only config in cmd_identity for local instances#13439ygd58 wants to merge 1 commit into
Conversation
…nstances cmd_identity() only checked _resolve_api_key(), blocking local Honcho instances that use base_url instead of an API key (issue NousResearch#2613). Changes to plugins/memory/honcho/cli.py: - Add _resolve_base_url() helper: reads baseUrl/base_url from host block and root level (camelCase + snake_case) - Add _is_configured() helper: returns True if api_key OR base_url is set — any valid auth method suffices - cmd_identity(): use _is_configured() instead of _resolve_api_key() so local no-auth instances can use the command Rebased from NousResearch#2619 to target current plugins/memory/honcho/ layout after honcho_integration/ was moved in refactor NousResearch#4623. Fixes NousResearch#2613
|
Rebased from #2619 (closed) onto current plugins/memory/honcho/ layout after pluggable memory refactor. |
|
Re-verified against current Recommend closing as superseded — happy to be corrected if I've misread the current state. |
|
Thanks for rebasing and preserving the local-instance use case. This is now implemented on
|
Problem
Local Honcho instances using
base_urlinstead of an API key could not usehermes honcho identity— it required an API key and exited early with "No API key configured".Fix
Adds to
plugins/memory/honcho/cli.py:_resolve_base_url()helper: readsbaseUrl/base_urlfrom host block and root level (camelCase + snake_case)_is_configured()helper: returnsTrueif eitherapi_keyORbase_urlis setcmd_identity(): uses_is_configured()instead of_resolve_api_key()onlyNote
Rebased from #2619 to target the current
plugins/memory/honcho/layout afterhoncho_integration/was moved in the pluggable memory provider refactor (#4623).Fixes #2613