fix(honcho): honor explicit peerName for user peer resolution - #13237
Closed
swhitt wants to merge 2 commits into
Closed
fix(honcho): honor explicit peerName for user peer resolution#13237swhitt wants to merge 2 commits into
swhitt wants to merge 2 commits into
Conversation
Author
|
need to rework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Honcho user peer resolution so an explicitly configured
peerNameis actually used as the user peer identity.Today, gateway
user_idwins overpeerName, which can split one person into multiple Honcho peers across transports. This changes the precedence to:peerNameuser_idThat keeps multi-user gateway behavior unchanged when
peerNameis unset, while making single-user / owner-operated setups behave as configured.Related Issue
Fixes #
Related: #9308
Type of Change
Changes Made
plugins/memory/honcho/session.pysoconfig.peer_namewins overruntime_user_peer_nametests/honcho_plugin/test_session.pyfor precedence, fallback, cross-transport identity, and sanitizationtests/agent/test_memory_user_id.pyto match the new precedencepeerNamebehavior in:plugins/memory/honcho/README.mdwebsite/docs/user-guide/features/memory-providers.mdoptional-skills/autonomous-ai-agents/honcho/SKILL.mdHow to Test
peerNameand use Hermes from multiple transports with different gatewayuser_idvaluespython -m pytest tests/honcho_plugin/test_session.py tests/agent/test_memory_user_id.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Targeted tests:
python -m pytest tests/honcho_plugin/test_session.py tests/agent/test_memory_user_id.py -q # 132 passed in 2.99sFull suite on this branch still has unrelated pre-existing failures outside this change, so I left the full-suite checkbox unchecked.