fix(gateway): prevent scoped lock and resource leaks on connection failure - #12916
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #12420 by @Ruzzgar onto current main.
Slack/Signal/WhatsApp adapters now release the scoped platform lock (plus Signal's httpx client and WhatsApp's bridge-log handle) when
connect()fails partway through, so in-process retries are no longer rejected as "already in use".Changes
gateway/platforms/signal.py:lock_acquiredflag + try/finally; also closeshttpx.AsyncClienton health-check failuregateway/platforms/slack.py: try/finally releases lock whenauth_test()or Socket Mode setup raisesgateway/platforms/whatsapp.py: unified failure paths — finally closes bridge log FH and releases lockValidation
PR's 3 new tests pass:
TestSignalConnectCleanup,TestSlackConnectCleanup,TestConnectCleanup(WhatsApp).Cherry-picked cleanly onto current main (141 commits ahead of the original branch point). Original authorship preserved.
Closes #12420.