Skip to content

fix: honor configured cwd during snapshot init - #12896

Closed
kaizhoumasha wants to merge 1 commit into
NousResearch:mainfrom
kaizhoumasha:fix/messaging-cwd-snapshot
Closed

fix: honor configured cwd during snapshot init#12896
kaizhoumasha wants to merge 1 commit into
NousResearch:mainfrom
kaizhoumasha:fix/messaging-cwd-snapshot

Conversation

@kaizhoumasha

Copy link
Copy Markdown

Summary

  • cd into the configured cwd before creating the local shell snapshot
  • prevent launchd WorkingDirectory from overriding the messaging workspace
  • add a regression test covering snapshot init with an explicit cwd

Verification

  • /Users/kaizhou/.hermes/hermes-agent/venv/bin/python -m pytest -q tests/tools/test_base_environment.py

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists tool/terminal Terminal execution and process management comp/tools Tool registry, model_tools, toolsets labels Apr 22, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #7802 — same fix: cd into configured cwd before capturing local shell snapshot. See also #9798 and #11019.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @kaizhoumasha! This fix was already merged to main via a different (but equivalent) approach before this PR could be merged.

Evidence:

This is an automated hermes-sweeper review. Closing as implemented on main.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants