Repository navigation
Python lints lane green again: portable bash shebang in the remote-lifecycle test fixture - #127265
Merged
Merged
Conversation
…cher fixture scripts/check_bash_shebangs.py (landed on main in #126164) now fails the Python lints lane for every PR: remote-lifecycle.test.ts writes a throwaway launcher script with `#!/bin/bash`. Use `#!/usr/bin/env bash` like every other script; the fixture only needs a bash that resolves on PATH.
૮ >ﻌ< ა ci reviewran on f6c9464 — fix(desktop): portable bash shebang in the remote-lifecycle all good! |
alt-glitch
added
type/test
Collaborator
|
Reviewed the one-line change. This Linux-only test just needs Bash to launch its temporary fixture, so |
kshitijk4poor
deleted the
fix/remote-lifecycle-test-portable-shebang
branch
September 29, 2026 07:58
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
Python lints / Windows footguns (blocking)lane is red on every PR sincescripts/check_bash_shebangs.pylanded (#126164, Sep 28):apps/desktop/electron/remote-lifecycle.test.ts:813writes a throwaway launcher fixture with#!/bin/bash.#!/usr/bin/env bash(the test only needs a bash that resolves on PATH; nothing else in the test reads the shebang).python scripts/check_bash_shebangs.pyon this branch:Bash shebang check: 0 violation(s).Seen on #127258 and #127245 (disjoint diffs, same red), which brackets the breakage to main between the two lints landing. No infographic: one-line CI unbreak.