fix: guard init-time stdio writes - #1271
Merged
Merged
Conversation
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…de3d4e49 fix: guard init-time stdio writes
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…de3d4e49 fix: guard init-time stdio writes
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…de3d4e49 fix: guard init-time stdio writes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #911 correctly identified that best-effort console output can still abort a gateway turn when stdio is broken. Current main already fixed the main run_conversation path with _SafeWriter, but there was still a smaller init-time gap before that guard was installed: the Honcho init fallback prints in AIAgent.init could still raise if stdout was already detached.
This patch fixes that remaining edge case on current main rather than layering a second print wrapper on top of the broader _SafeWriter approach.
Test plan