fix(gateway): honor MATRIX_HOME_ROOM in onboarding - #12698
Closed
mikeyobrien wants to merge 1 commit into
Closed
Conversation
mikeyobrien
marked this pull request as ready for review
April 19, 2026 21:46
Contributor
|
Thanks @mikeyobrien — merged as PR #18272. Your fix was the right approach: single source of truth via |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Matrix home delivery is configured with
MATRIX_HOME_ROOM, but Hermes could still warn that no Matrix home target was set. The warning path and/sethomewere not using the same home-target env-var mapping, so Matrix looked misconfigured even when it was correct.Fixes N/A
Root Cause
gateway/run.pystill had logic that assumedMATRIX_HOME_CHANNELin the onboarding warning path, while Matrix actually usesMATRIX_HOME_ROOM./sethomeand onboarding were not grounded on the same shared mapping.Fix
/sethomeuse the same mapping instead of assuming*_HOME_CHANNELHow to Verify
MATRIX_HOME_ROOM./sethomefor Matrix and confirm the command resolves the same env-var mapping as onboarding.Test Plan
Commands run:
PYTEST_ADDOPTS= pytest -q tests/gateway/test_home_target_env_var.py tests/gateway/test_steer_command.py tests/gateway/test_unauthorized_dm_behavior.pyPYTEST_ADDOPTS= pytest -q tests/gateway/test_home_target_env_var.py tests/gateway/test_matrix.py tests/cron/test_scheduler.pyRisk Assessment
Low — the change narrows behavior onto the existing shared home-target mapping and adds regression coverage around Matrix and fallback resolution.