fix(delegate): add missing task_count to _build_child_agent() call sites - #12697
Closed
MestreY0d4-Uninter wants to merge 4 commits into
Closed
fix(delegate): add missing task_count to _build_child_agent() call sites#12697MestreY0d4-Uninter wants to merge 4 commits into
MestreY0d4-Uninter wants to merge 4 commits into
Conversation
…rom_cli - Add account-identity verification before syncing tokens from ~/.codex/auth.json - Fail closed if CLI identity cannot be proven to match the pool entry - Add mark_success(), size(), active_lease_count() helpers to CredentialPool - Tests: 3 sync identity guard + mark_success persistence Extracted from refreshed audit of stale PR NousResearch#5692.
Fixes regression from PR NousResearch#11155 reported by @trevorgordon981.
Contributor
Author
|
Closing as this has been absorbed into main. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical regression introduced in PR #11155 where the
_build_child_agent()function signature was updated to requiretask_countas a mandatory parameter, but the call sites were not updated accordingly.Bug Report
TypeError: _build_child_agent() missing 1 required positional argument: 'task_count'Changes
tools/delegate_tool.py:892— Addedtask_count=n_tasksto the_build_child_agent()call sitetests/tools/test_delegate_tier_core.py:105— Addedtask_count=1to the test callValidation
All tests passing (82/82):
test_delegate_tier_core.py(NEW): 10/10 PASStest_delegate.py(EXISTING): 67/67 PASStest_delegate_toolset_scope.py: 5/5 PASSFollows
Fixes regression from PR #11155.