fix(telegram): require entity mentions for group gating - #12637
Closed
MonkeyLeeT wants to merge 1 commit into
Closed
fix(telegram): require entity mentions for group gating#12637MonkeyLeeT wants to merge 1 commit into
MonkeyLeeT wants to merge 1 commit into
Conversation
MonkeyLeeT
marked this pull request as ready for review
April 19, 2026 21:08
MonkeyLeeT
force-pushed
the
codex/fix-12545-telegram-mention-gating
branch
3 times, most recently
from
April 20, 2026 16:38
3cd3638 to
6a8ac5b
Compare
MonkeyLeeT
force-pushed
the
codex/fix-12545-telegram-mention-gating
branch
from
April 20, 2026 19:18
6a8ac5b to
c01aaad
Compare
Contributor
|
Thanks for the contribution @MonkeyLeeT — closing as redundant. Commit e330112 on main refactored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Telegram group mention gating so only real Telegram mention entities wake the bot.
Root Cause
TelegramAdapter._message_mentions_bot()returnedTrueon any raw@<bot_username>substring before checking Telegram entities. That let unrelated text likefoo@hermes_bot.exampleand longer handles like@hermes_botxbypassrequire_mention=true.Changes
gateway/platforms/telegram.pymentionandtext_mentionhandling intacttests/gateway/test_telegram_group_gating.pyValidation
scripts/run_tests.sh tests/gateway/test_telegram_group_gating.py -qCloses #12545.