Skip to content

fix(api-server): GET /v1/skills passes include_editorial to a functio… - #126086

Open
lvipclub wants to merge 1 commit into
NousResearch:mainfrom
lvipclub:fix/v1-skills-include-editorial-revert
Open

lvipclub wants to merge 1 commit into
NousResearch:mainfrom
lvipclub:fix/v1-skills-include-editorial-revert

Conversation

@lvipclub

Copy link
Copy Markdown

…n that no longer accepts it

PR #94266 (Collective Wisdom V1) added an include_editorial kwarg to _find_all_skills and updated this call site; the same-day revert (0dcadf6) removed the parameter but left the call site passing it, so every GET /v1/skills raises TypeError and returns 500 'Failed to enumerate skills'.

Restore the pre-wisdom call shape _find_all_skills(skip_disabled=False) — exactly what the revert should have restored. No editorial concept exists anywhere in the skills system post-revert.

Add an endpoint test that exercises the unmocked discovery path against a real skill on disk; the existing envelope test mocks _find_all_skills, which is why the 500 was never caught.

(cherry picked from commit 9c64d7909c0b5b9158a620af94c2772b9211e3e5)

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

…n that no longer accepts it

PR NousResearch#94266 (Collective Wisdom V1) added an include_editorial kwarg to
_find_all_skills and updated this call site; the same-day revert
(0dcadf6) removed the parameter but left the call site passing it,
so every GET /v1/skills raises TypeError and returns 500
'Failed to enumerate skills'.

Restore the pre-wisdom call shape _find_all_skills(skip_disabled=False)
— exactly what the revert should have restored. No editorial concept
exists anywhere in the skills system post-revert.

Add an endpoint test that exercises the unmocked discovery path against
a real skill on disk; the existing envelope test mocks _find_all_skills,
which is why the 500 was never caught.

(cherry picked from commit 9c64d7909c0b5b9158a620af94c2772b9211e3e5)
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery tool/skills Skills system (list, view, manage) labels Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants