Conversation
…n that no longer accepts it PR NousResearch#94266 (Collective Wisdom V1) added an include_editorial kwarg to _find_all_skills and updated this call site; the same-day revert (0dcadf6) removed the parameter but left the call site passing it, so every GET /v1/skills raises TypeError and returns 500 'Failed to enumerate skills'. Restore the pre-wisdom call shape _find_all_skills(skip_disabled=False) — exactly what the revert should have restored. No editorial concept exists anywhere in the skills system post-revert. Add an endpoint test that exercises the unmocked discovery path against a real skill on disk; the existing envelope test mocks _find_all_skills, which is why the 500 was never caught. (cherry picked from commit 9c64d7909c0b5b9158a620af94c2772b9211e3e5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n that no longer accepts it
PR #94266 (Collective Wisdom V1) added an include_editorial kwarg to _find_all_skills and updated this call site; the same-day revert (0dcadf6) removed the parameter but left the call site passing it, so every GET /v1/skills raises TypeError and returns 500 'Failed to enumerate skills'.
Restore the pre-wisdom call shape _find_all_skills(skip_disabled=False) — exactly what the revert should have restored. No editorial concept exists anywhere in the skills system post-revert.
Add an endpoint test that exercises the unmocked discovery path against a real skill on disk; the existing envelope test mocks _find_all_skills, which is why the 500 was never caught.
(cherry picked from commit 9c64d7909c0b5b9158a620af94c2772b9211e3e5)
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs