fix(cron): show delivery failure inline with last-run status - #12592
Closed
williams145 wants to merge 1 commit into
Closed
williams145 wants to merge 1 commit into
williams145 wants to merge 1 commit into
Conversation
When a cron job's agent run succeeds but delivery to a channel
(Discord, Telegram, etc.) fails, `last_status` is "ok" while
`last_delivery_error` holds the failure reason. The previous display
printed a separate yellow warning line that was easy to miss — the
status cell still showed a plain green "ok", making the job look
healthy at a glance.
This commit surfaces the failure directly in the status cell:
hermes_cli/cron.py (`hermes cron list`)
"ok" → "ok ⚠ delivery failed" (green + yellow) when
`last_delivery_error` is set; the detail line below is kept.
cli.py (in-chat /cron list)
Status string becomes "ok ⚠ delivery failed" and a
"Delivery error: …" line is printed below it.
No changes to cron/jobs.py or the data model — `last_status` still
reflects agent execution only, per the maintainer design decision.
Fixes NousResearch#5861
williams145
force-pushed
the
fix/issue-5861-delivery-error-display-v2
branch
from
April 19, 2026 15:29
42c12de to
c08accb
Compare
alt-glitch
added
type/bug
This was referenced May 1, 2026
Author
|
Friendly bump — fix still applies cleanly to current main ( |
Author
|
Closing — no maintainer engagement since opening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a cron job succeeds at running the agent but fails to deliver the output (Discord, Telegram, etc.),
last_statusis"ok"while the failure sits silently inlast_delivery_error. The previous display printed a yellow warning on a separate line — easy to miss, and the status cell still showed a plain green ok, making the job look healthy at a glance.Fix
hermes_cli/cron.py(hermes cron listterminal command):When
last_delivery_erroris set and status is"ok", the status cell now renders asok ⚠ delivery failed(green + yellow) instead of justok. The detail line below it is kept.cli.py(in-chat/cron list):Status string becomes
ok ⚠ delivery failedand aDelivery error: …line is printed below.No changes to
cron/jobs.pyor the data model —last_statuscontinues to reflect agent execution only, consistent with the
maintainer design in commit
c5ab760.Testing
Fixes #5861