Skip to content

feat(plugins): allow plugins to register custom platform adapters via… - #12475

Closed
luckylhb90 wants to merge 1 commit into
NousResearch:mainfrom
luckylhb90:feat/plugin-platform-adapters
Closed

feat(plugins): allow plugins to register custom platform adapters via…#12475
luckylhb90 wants to merge 1 commit into
NousResearch:mainfrom
luckylhb90:feat/plugin-platform-adapters

Conversation

@luckylhb90

@luckylhb90 luckylhb90 commented Apr 19, 2026

Copy link
Copy Markdown

… register_platform_adapter()

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/gateway Gateway runner, session dispatch, delivery labels Apr 23, 2026
@luckylhb90
luckylhb90 force-pushed the feat/plugin-platform-adapters branch from 2a2443e to 36e5cd5 Compare April 30, 2026 23:57
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the platform-plugin proposal. This is now implemented on current main through a broader, integrated registry design; this is an automated hermes-sweeper review.

  • hermes_cli/plugins.py:929 exposes ctx.register_platform(...), which creates a PlatformEntry and registers it with the shared registry.
  • gateway/run.py:8645 resolves registered adapters before the built-in adapter chain.
  • gateway/platform_registry.py:278 validates requirements/configuration and invokes the registered adapter factory.
  • The implementation was introduced by 8f144fe36b2ab4ea353d9ce2d1b69552f2726312 and is contained in release tag v2026.4.30.
  • The related larger salvage discussed in feat: pluggable gateway gateway platforms as plugins #17664 is reflected in the current registry, docs, and test coverage.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants