fix: preserve dots in Bedrock inference-profile IDs (#12295) - #12336
Closed
vominh1919 wants to merge 1 commit into
Closed
fix: preserve dots in Bedrock inference-profile IDs (#12295)#12336vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
…ch#12295) AWS Bedrock inference-profile IDs like us.anthropic.claude-sonnet-4-5-20250929-v1:0 contain dots that must not be collapsed to hyphens. Without preserve_dots=True, normalize_model_name() was mangling these IDs, causing HTTP 400 errors from Bedrock. - Add 'bedrock' to the provider set in _anthropic_preserve_dots() - Add 'bedrock-runtime' to the base_url URL check - Add 4 new tests covering provider, URL, and normalize_model_name behavior
|
✓ Automated scan: no security concerns. Bedrock profile ID fix. |
Collaborator
13 tasks
Contributor
|
Thanks for the fix, @vominh1919! This bug was real and the approach here is correct. This is an automated hermes-sweeper review. After inspecting
Both commits are confirmed ancestors of the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12295
_anthropic_preserve_dots()didn't include 'bedrock' in the providers that preserve dots. AWS Bedrock inference-profile IDs likeus.anthropic.claude-sonnet-4-5-20250929-v1:0were mangled tous-anthropic-claude-sonnet-4-5-20250929-v1:0, causing HTTP 400.Changes:
"bedrock"to provider set in_anthropic_preserve_dots()"bedrock-runtime"to base_url fallback check