fix(gateway): finalize session-end memory providers with transcript - #12261
Closed
MonkeyLeeT wants to merge 1 commit into
Closed
fix(gateway): finalize session-end memory providers with transcript#12261MonkeyLeeT wants to merge 1 commit into
MonkeyLeeT wants to merge 1 commit into
Conversation
MonkeyLeeT
marked this pull request as ready for review
April 18, 2026 19:50
MonkeyLeeT
force-pushed
the
codex/fix-11205-gateway-memory-finalize
branch
from
April 18, 2026 19:52
fa0c161 to
e920d90
Compare
Author
|
Closing this duplicate fix in favor of existing PRs already covering #11205. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/new//resetshutdown_memory_provider(history)before closing stale agentsRoot Cause
The gateway already had a built-in memory flush path, but its real session-boundary paths did not finalize
MemoryProvider.on_session_end()correctly. Session expiry called provider shutdown without the transcript, and/new//resetonly scheduled the built-in flush before closing the cached agent. That meant memory providers never received the actual session messages they need to persist end-of-session state.Validation
source .venv/bin/activate && python -m pytest tests/gateway/test_async_memory_flush.py tests/gateway/test_session_model_reset.py tests/gateway/test_session_boundary_hooks.py tests/gateway/test_resume_command.py tests/gateway/test_gateway_shutdown.py -qCloses #11205.