-
Notifications
You must be signed in to change notification settings - Fork 46.7k
fix: accept max reasoning effort #12211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1189,7 +1189,7 @@ def _load_reasoning_config() -> dict | None: | |
| """Load reasoning effort from config.yaml. | ||
|
|
||
| Reads agent.reasoning_effort from config.yaml. Valid: "none", | ||
| "minimal", "low", "medium", "high", "xhigh". Returns None to use | ||
| "minimal", "low", "medium", "high", "xhigh", "max". Returns None to use | ||
| default (medium). | ||
| """ | ||
| from hermes_constants import parse_reasoning_effort | ||
|
|
@@ -6371,7 +6371,7 @@ async def _handle_reasoning_command(self, event: MessageEvent) -> str: | |
|
|
||
| Usage: | ||
| /reasoning Show current effort level and display state | ||
| /reasoning <level> Set reasoning effort (none, minimal, low, medium, high, xhigh) | ||
| /reasoning <level> Set reasoning effort (none, minimal, low, medium, high, xhigh, max) | ||
| /reasoning show|on Show model reasoning in responses | ||
|
Comment on lines
6371
to
6375
|
||
| /reasoning hide|off Hide model reasoning from responses | ||
| """ | ||
|
|
@@ -6438,12 +6438,12 @@ def _save_config_key(key_path: str, value): | |
| effort = args.strip() | ||
| if effort == "none": | ||
| parsed = {"enabled": False} | ||
| elif effort in ("minimal", "low", "medium", "high", "xhigh"): | ||
| elif effort in ("minimal", "low", "medium", "high", "xhigh", "max"): | ||
| parsed = {"enabled": True, "effort": effort} | ||
| else: | ||
| return ( | ||
| f"⚠️ Unknown argument: `{effort}`\n\n" | ||
| "**Valid levels:** none, minimal, low, medium, high, xhigh\n" | ||
| "**Valid levels:** none, minimal, low, medium, high, xhigh, max\n" | ||
| "**Display:** show, hide" | ||
| ) | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,13 +138,13 @@ def get_subprocess_home() -> str | None: | |
| return None | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepting |
||
|
|
||
|
|
||
| VALID_REASONING_EFFORTS = ("minimal", "low", "medium", "high", "xhigh") | ||
| VALID_REASONING_EFFORTS = ("minimal", "low", "medium", "high", "xhigh", "max") | ||
|
|
||
|
|
||
| def parse_reasoning_effort(effort: str) -> dict | None: | ||
| """Parse a reasoning effort level into a config dict. | ||
|
|
||
| Valid levels: "none", "minimal", "low", "medium", "high", "xhigh". | ||
| Valid levels: "none", "minimal", "low", "medium", "high", "xhigh", "max". | ||
| Returns None when the input is empty or unrecognized (caller uses default). | ||
| Returns {"enabled": False} for "none". | ||
| Returns {"enabled": True, "effort": <level>} for valid effort levels. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/reasoninghelp text now listsmax, but the no-args status output later in this handler still printsUsage: /reasoning <none|minimal|low|medium|high|xhigh|show|hide>(missingmax). Please update that usage hint too so all CLI help surfaces are consistent.