fix(email): add email SMTP STARTTLS fallback - #12161
Closed
hxp-plus wants to merge 1 commit into
Closed
Conversation
Collaborator
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
19 tasks
This was referenced Jun 14, 2026
Contributor
Author
|
This issue is solved in lateset code. Closing the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes SMTP connection handling in the email gateway so both implicit TLS on port 465 and STARTTLS on port 587 work correctly.
Previously, the adapter expects a plain SMTP connection upgraded with STARTTLS on port 587 and can not handle SMTP servers with port 465 with
SMTP SSL. This PR unifies SMTP connection paths behind a single flow:smtplib.SMTP(...)and upgrade viastarttls(...)smtplib.SMTP_SSL(...)This keeps 587-compatible servers working while preserving support for 465-only SMTP setups.
Related Issue
Fixes #11842
Type of Change
Changes Made
gateway/platforms/email.pyconnect()_send_email()_send_email_with_attachment()tests/gateway/test_email.pyfor:How to Test
connect()and message sending still workconnect()and message sending work viaSMTP_SSLscripts/run_tests.sh tests/gateway/test_email.py -qscripts/run_tests.sh tests/gateway/ -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/Aguide — or N/A
Screenshots / Logs
N/A