Repository navigation
fix(a2a): preserve late reply waiters and reject undelivered finals - #121577
Closed
RuniThomsen wants to merge 1 commit into
Closed
RuniThomsen wants to merge 1 commit into
RuniThomsen wants to merge 1 commit into
Conversation
Agent: hermes_runi
Author
|
Superseded by upstream work in #96983; closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Both regressions were observed failing on the original implementation before their fixes. After rebasing onto main deb4bd2:
scripts/run_tests.sh tests/plugins/test_a2a_late_reply.py tests/plugins/test_a2a_plugin.py tests/plugins/test_a2a_phase23.py tests/plugins/test_a2a_tools_gate.pyResult: 142 passed, 0 failed across four files.
Scope and limitations
No credential, identity, configuration or runtime activation changes. Disconnect behavior remains failed; this does not implement durable disconnected-client recovery or unsolicited background delivery. Existing context-oldest reply selection is unchanged. A lost processing callback can still retain a waiter until cancellation/shutdown; review this lifecycle boundary explicitly.
Production acceptance is pending: three consecutive caller-observed replies, including one deliberately past the observation deadline. Unit/subsystem tests are not that live proof.