fix(sessions): return archived pins from the sidebar back-fill - #121444
Merged
Merged
Conversation
The include_pinned query reused the listing WHERE, including archived = 0. The sidebar lists with include_archived=False, so a pinned row stamped archived never back-filled. Rebuild that query without the archived constraint and keep the other filters. The stale sweep already skips pins.
OutThisLife
enabled auto-merge (rebase)
September 24, 2026 11:17
૮ >ﻌ< ა ci reviewran on 023ea0e — fix(sessions): return archived pins from the sidebar back-fi
|
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sidebar back-fill reused a WHERE that required
archived = 0, so a pinned session that was also archived never returned. The pin query now usespinned = 1and drops only that archived constraint. Source, message-count, child, and hidden filters still apply. The stale sweep already skipped pins and was not changed.The history-wipe claim in the report was not reproduced. No deleter was added.
Test plan
scripts/run_tests.sh tests/hermes_state/test_pinned_archived_sidebar.py— 1 failed on base, 3 passed after.#104301 is copy only. It was not cherry-picked.
Auto-merge: rebase. Reviewed head
023ea0ec392c. The main list query is unchanged. Only the pin back-fill drops the archived constraint.Fixes #71866