test(tools): add unit tests for clarify_tool.py

[Bartok9]

Summary

Add comprehensive test coverage for the clarify_tool module that handles interactive clarifying questions.

Changes

• Add tests/tools/test_clarify_tool.py with 20 unit tests

Test Coverage

TestClarifyToolBasics (5 tests)

• Simple question with callback
• Question with choices
• Empty question returns error
• Whitespace-only question returns error
• No callback returns error

TestClarifyToolChoicesValidation (5 tests)

• Choices trimmed to MAX_CHOICES (4)
• Empty choices list becomes None
• Whitespace-only choices stripped
• Invalid choices type returns error
• Non-string choices converted to strings

TestClarifyToolCallbackHandling (3 tests)

• Callback exception returns error
• Callback receives stripped question
• User response is stripped

TestCheckClarifyRequirements (1 test)

• Always returns True (no external deps)

TestClarifySchema (6 tests)

• Schema name is 'clarify'
• Schema has description
• Question is required
• Choices is optional
• Choices has maxItems constraint
• MAX_CHOICES constant is 4

Testing

uv run pytest tests/tools/test_clarify_tool.py -v
# 20 passed

[shang-vikas]

Deployment Verification Report

Hooks Installed

Hook	File	Status	Lines Added
#116 — Prompt footer	agent/conversation_loop.py	✅ INSTALLED	+14
#117 — Skill load observer	tools/skills_tool.py	✅ INSTALLED	+9
#118 — Session finalizer	hermes_state.py	✅ INSTALLED	+8

Bundle

Check	Status
Bundle validated (14 files)	✅ PASS
Model loads + inference works	✅ PASS
Symlink in venv site-packages	✅ CONFIRMED

Cron Jobs

Job	Schedule	Status
p8-session-finalizer	Every 5 min	✅ ACTIVE
p8-stage1-monitor	Every 10 min	✅ ACTIVE

Environment

Variable	Value
P7_HOOKS_MODE	off (set in .zshrc + .bashrc)

End-to-End Test

Test	Result
build_skill_footer(mode=off) → empty string	✅ PASS
build_skill_footer(mode=hybrid) → 5 suggestions	✅ PASS (286 chars)
observe_skill_load() → telemetry written	✅ PASS
finalize_session() → outcome written	✅ PASS
Health counters incrementing	✅ PASS

Next

Stage 1 (invisible) is live. Monitor reports here every 10 min. After 100 sessions, switch to Stage 2 (10% visible footer).