Skip to content

fix(gateway): fix dictionary iteration race condition during stop #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iso2kx wants to merge 1 commit into from
Closed

fix(gateway): fix dictionary iteration race condition during stop #1195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,8 @@ async def stop(self) -> None:
logger.info("Stopping gateway...")
self._running = False

for platform, adapter in self.adapters.items():
# Iterate over a copy to avoid "dictionary changed size during iteration"
for platform, adapter in list(self.adapters.items()):
try:
await adapter.disconnect()
logger.info("✓ %s disconnected", platform.value)
Expand Down