Plugin catalog: nvidia-app and nvidia-broadcast (official, Windows only) - #119265
Merged
Merged
Conversation
…ows only) Two portable Agent Plugins from NousResearch/hermes-nvidia, one per NVIDIA application, each in its own subdir of the repo and pinned to 5023f3a4ea. Both declare the application they need through the plugin.json extensions namespace: install is refused when the app is absent or too old (NS-942), and the tools appear only while the app is running (NS-943). `platforms: [windows]` is the catalog-level gate; the declaration is the per-server gate. Proven live on two Windows machines (ARM64 laptop and x64 desktop): 12 NVIDIA App tools and 10 NVIDIA Broadcast tools registered from real sessions; the x64 desktop installed the package from the desktop deep link and the model called the tools. The evidence rows are in the plugin repo. The repository is private until release. The catalog CI clone step is expected to fail for these two entries until the repo is flipped public; the static validation job passes (240 entries).
૮ >ﻌ< ა ci reviewran on 47b1077 — feat(plugin-catalog): nvidia-app and nvidia-broadcast (offic debug infoCI timingsCI timings · View report · View jobWall time 5m51s vs 6m19s (-7.4%). 7 job(s) slower, 3 faster, 2 unchanged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two NVIDIA plugins join the catalog:
nvidia-appandnvidia-broadcast, Windows only, official tier.What they are
Portable Agent Plugins (no Python of their own) from
NousResearch/hermes-nvidia, one per NVIDIA application,each in its own subdirectory of the repo, both pinned to
5023f3a4ea. Each carries one MCP server entry(the vendor's own local server), one skill, and an application declaration under
plugin.json → extensions["com.nousresearch.hermes"].servers.nvidia-appMcpServer/server.jsonon every connectionnvidia-broadcast18100-18109; needs the app running in the user's desktop sessionWhat gates them
flowchart LR A["hermes plugins install nvidia-app<br/>(or the catalog card / deep link)"] --> B{"platforms: [windows]<br/>catalog gate"} B -- other OS --> R1["refused: unsupported_os"] B -- Windows --> C{"declaration:<br/>app present ≥ min version?"} C -- no --> R2["refused before the swap:<br/>missing_app / version_too_old"] C -- yes --> D["installed + enabled"] D --> E{"liveness at connect time"} E -- app running --> F["tools registered"] E -- not running --> G["card pill + catalog line:<br/>'start NVIDIA Broadcast'"]The catalog
platformsfield is the coarse gate (plugins_cmd_catalog.py::_refuse_unsupported_catalog_platform);the per-server declaration is the fine one (NS-942, #119049). Neither launches anything.
Evidence
Two real Windows machines, real sessions, upstream
main:MCP: registered 22 tool(s) from 2 server(s)hermes plugins validate→server availability: … unsupported_os, install refusedRows with timestamps are in the plugin repo's
EVIDENCE.md.Expected CI state
validatejob (schema + static checks): green, 240 entries.pinned-shajob: red for these two entries until the repo is public. It does a plaingit cloneon apublic runner; the repo is private until release. That is the only expected failure. Flip the repo public, re-run,
and the job clones and validates at the pin.
Notes for the reviewer
mainthese register asmcp__agent_plugin_nvidia_app_<sha8>__nvidia_app__…, over 64chars and hash-clamped. Portable plugin MCP tools keep their names instead of a hash (64-char provider cap) #119263 fixes the loader namespace so they come out as
mcp__nvidia_app__nvapp_client_get_driver_status. Independent of this PR; better together.security scan — cautiononnvidia-broadcast: one line in the vendor skill (dump_all_env, a documentedtroubleshooting step). Read at admission per catalog rule 7; a catalog install accepts it without a prompt.