Skip to content

fix(api_server): drop nonexistent include_editorial kwarg from GET /v1/skills #117048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisworksai wants to merge 1 commit into from
Closed

fix(api_server): drop nonexistent include_editorial kwarg from GET /v1/skills #117048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions gateway/platforms/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2705,11 +2705,7 @@ async def _handle_skills(self, request: "web.Request") -> "web.Response":
category), the same set ``/skills list`` shows."""
try:
from tools.skills_tool import _find_all_skills, _sort_skills
skills = _sort_skills(
_find_all_skills(
skip_disabled=False, include_editorial=True
)
)
skills = _sort_skills(_find_all_skills(skip_disabled=False))
except Exception:
logger.exception("GET /v1/skills failed")
return _error_response("Failed to enumerate skills", 500, err_type="server_error")
Expand Down
4 changes: 4 additions & 0 deletions tests/gateway/test_api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,8 +1034,12 @@ async def test_skills_returns_list_envelope(self, adapter):
{"name": "github", "description": "GitHub workflow skill", "category": "github"},
{"name": "ascii-art", "description": "ASCII art generation", "category": "creative"},
]
# autospec=True enforces the real _find_all_skills signature. Without it the
# kwargs-blind MagicMock swallowed a stale keyword argument and this test stayed
# green while the live route raised TypeError and answered 500 on every request.
with patch(
"tools.skills_tool._find_all_skills",
autospec=True,
return_value=list(fake_skills),
):
app = _create_app(adapter)
Expand Down