fix(api): drop revert-lost include_editorial kwarg from /v1/skills handler - #115681
Closed
trevor-commits wants to merge 1 commit into
Closed
trevor-commits wants to merge 1 commit into
trevor-commits wants to merge 1 commit into
Conversation
…ndler The Collective Wisdom revert (0dcadf6) removed the include_editorial parameter from _find_all_skills but missed the GET /v1/skills caller in gateway/platforms/api_server.py. Every authenticated GET /v1/skills raised TypeError -> HTTP 500. Verified locally: pytest tests/gateway/test_api_server.py 119 passed; endpoint returns 200 with the skill list.
|
Independent verification on the PR head (9e6da77): api-server suite 119/119 green on Linux. Dropping the revert-lost kwarg keeps the handler honest: it no longer passes an argument the callee never accepted. One-line revert repair, no behavior change beyond un-breaking the call. No findings. |
alt-glitch
added
type/bug
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix for the incomplete Collective Wisdom revert 0dcadf6.
Problem: the revert removed
include_editorialfromtools/skills_tool.py::_find_all_skillsbut missed the caller in
gateway/platforms/api_server.py::_handle_skills(GET /v1/skills).Every authenticated
GET /v1/skillsraisesTypeError: _find_all_skills() got an unexpected keyword argument 'include_editorial'-> HTTP 500.Repro: enable the API server, then
curl -H 'Authorization: Bearer <key>' http://host:8642/v1/skills-> 500.Fix: drop the stale kwarg at the call site.
Verified locally:
pytest tests/gateway/test_api_server.py-> 119 passed;endpoint returns 200 with the skill list.