Skip to content

Treat failed skill loads as actual command failures - #11545

Closed
cola-runner wants to merge 2 commits into
NousResearch:mainfrom
cola-runner:codex/fix-11200-skill-load-failure
Closed

Treat failed skill loads as actual command failures#11545
cola-runner wants to merge 2 commits into
NousResearch:mainfrom
cola-runner:codex/fix-11200-skill-load-failure

Conversation

@cola-runner

@cola-runner cola-runner commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Closes #11200

Summary

  • return None when a cached skill command can no longer load its payload, instead of injecting a bracketed placeholder into the model prompt
  • surface known skill load failures to gateway users so broken /skill commands do not fall through to the agent as plain text
  • add regressions for post-scan skill deletion plus CLI/gateway failure handling

Testing

  • source venv/bin/activate && python -m pytest tests/agent/test_skill_commands.py tests/gateway/test_unknown_command.py tests/cli/test_cli_prefix_matching.py tests/gateway/test_webhook_integration.py -q
  • source venv/bin/activate && python -m pytest tests/ -q

Full tests/ -q still reflects the current repo baseline in this environment: 73 failed, 12120 passed, 104 skipped, 50 errors, dominated by existing ACP / FastAPI web / gateway / run_agent failures unrelated to this change.

@cola-runner

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate of the earlier fixes already linked on #11200 (#11380 and #11408). I missed the existing linked PRs before sending this one up, so I'm clearing it out to avoid duplicate review traffic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Skill load failure is treated as successful slash-command invocation

1 participant