Skip to content

fix: only send think=false to Ollama, not all custom providers #11520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vominh1919 wants to merge 1 commit into from
Closed

fix: only send think=false to Ollama, not all custom providers #11520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6786,7 +6786,14 @@ def _build_api_kwargs(self, api_messages: list) -> dict:
# This prevents thinking-capable models (Qwen3, etc.) from generating
# <think> blocks and producing empty-response errors when the user has
# set reasoning_effort: none.
if self.provider == "custom" and self.reasoning_config and isinstance(self.reasoning_config, dict):
# Only send think=false to Ollama — other custom providers
# (Mistral, Fireworks, Together.ai, vLLM) reject unknown params. (#11237)
_is_ollama = bool(
self._ollama_num_ctx
or "ollama" in self._base_url_lower
or ":11434" in self._base_url_lower
)
if _is_ollama and self.provider == "custom" and self.reasoning_config and isinstance(self.reasoning_config, dict):
_effort = (self.reasoning_config.get("effort") or "").strip().lower()
_enabled = self.reasoning_config.get("enabled", True)
if _effort == "none" or _enabled is False:
Expand Down
Loading