fix(desktop): scope sidebar session search to active profile - #114102
Open
cspiritsong wants to merge 1 commit into
Open
cspiritsong wants to merge 1 commit into
cspiritsong wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scopes desktop sidebar full-text session search to the active profile context.
Currently,
searchSessions()inapps/desktop/src/api/sessions.tsqueries/api/sessions/searchwithout passing a profile parameter, causing search to hit the primary database even when browsing a concrete profile.This wires the active
profileScopethroughsearchSessions, keeps All Profiles unscoped, and adds a scope-tracking guard (serverMatchesScope) to drop in-flight responses from a prior profile after a switch.Successor to #83640 (narrowed to search following #87566's cache salvage, reopened on a fresh head after upstream refactors).
Tested via vitest (
src/hermes.test.ts) and manual profile switching.