fix(auth): keep manual Codex pool entries isolated - #11382
Closed
yeyitech wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
Thanks for the careful fix and regression test, @yeyitech! This is a well-reasoned narrower guard. However, this PR can no longer be merged — the function it patches (
The underlying bug this PR addresses is resolved. Closing as implemented on main. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_sync_codex_entry_from_cli()so only the singletondevice_codeentry can sync from~/.codex/auth.jsonmanual:device_codepool entries isolated from the shared Codex CLI token storeCloses #11364.
Testing
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest -o addopts= tests/agent/test_credential_pool.py -q