Skip to content

docs(claude-code): default to permission prompts - #113456

Closed
KoNit-K wants to merge 1 commit into
NousResearch:mainfrom
KoNit-K:fix/claude-code-safe-permissions-113447
Closed

KoNit-K wants to merge 1 commit into
NousResearch:mainfrom
KoNit-K:fix/claude-code-safe-permissions-113447

Conversation

@KoNit-K

@KoNit-K KoNit-K commented Sep 16, 2026

Copy link
Copy Markdown

What does this PR do?

Claude Code’s interactive tmux example now starts with normal permission prompts instead of automatically launching with --dangerously-skip-permissions. The skill distinguishes per-request review from a scoped acceptEdits automation mode, and keeps full permission bypass as an explicit, high-risk choice for isolated environments.

Related Issue

Fixes #113447

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Changes Made

  • skills/autonomous-ai-agents/claude-code/SKILL.md — replaced the default bypass launch and blanket dialog acceptance with normal permission handling.
  • skills/autonomous-ai-agents/claude-code/SKILL.md — documented --permission-mode acceptEdits as a reviewed, narrower automation option and restricted full bypass guidance to deliberate isolated-use opt-in.

How to Test

  • HERMES_PYTHON=/Users/blockkonit./Dev/hermes/hermes-agent/.venv/bin/python scripts/run_tests.sh tests/skills/test_authoring_standards.py -q — 1,250 passed.
  • Focused policy assertions verify the normal-permissions default, the explicit acceptEdits mode, the bypass warning, and the removal of the old blanket-accept example — 5 passed.

Evidence

  • BEFORE RED: the focused policy assertion failed with missing normal-permissions default, because the robust dialog example launched with --dangerously-skip-permissions.
  • AFTER GREEN: the same policy check passed 5 assertions after the example was changed to normal prompts and bypass was isolated as opt-in.
  • CONTROL: tests/skills/test_authoring_standards.py passed 1,250 tests; git diff --check passed and the diff contains only the Claude Code skill file.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix
  • I've run relevant tests locally (see How to Test)
  • Documentation policy checks cover the changed guidance
  • I've tested on my platform: macOS

Documentation & Housekeeping

  • Documentation update: included
  • cli-config.yaml.example: N/A
  • CONTRIBUTING.md or AGENTS.md: N/A
  • Cross-platform impact considered
  • Tool descriptions/schemas: N/A

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) labels Sep 16, 2026
@KoNit-K
KoNit-K force-pushed the fix/claude-code-safe-permissions-113447 branch from 8f9d50c to e61cb2f Compare September 17, 2026 13:54
teknium1 added a commit that referenced this pull request Sep 18, 2026
… in the flag table

- Dialog 2 now shows the read-then-answer step for one benign prompt and
  warns against blind timed Enter, and names --permission-mode acceptEdits
  as the narrower opt-in (idea from PR #113456).
- Quick Reference row and pitfall #2 carry the opt-in wording instead of
  teaching Down+Enter as the expected move.
- Regenerated the claude-code docs page.
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks @KoNit-K. Your change was salvaged into #114781 with your authorship preserved (co-authored); #114781 — docs(skills): coding-agent delegation skill defaults to permission prompts; bypass is an explicit opt-in (#113447, salvage #113464) — is now merged on main at c55b5bb6ceed, closing issues #113447. Closing this PR in favour of the landed change; if you see a case it does not cover, please open a fresh issue with the repro and tag it.

@teknium1 teknium1 closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: claude-code skill standardizes on --dangerously-skip-permissions as the default flow

3 participants