Skip to content

fix 11201: fix auto-title guard to use >= 2 - #11280

Open
vominh1919 wants to merge 1 commit into
NousResearch:mainfrom
vominh1919:fix/11201-auto-title-second-exchange
Open

fix 11201: fix auto-title guard to use >= 2#11280
vominh1919 wants to merge 1 commit into
NousResearch:mainfrom
vominh1919:fix/11201-auto-title-second-exchange

Conversation

@vominh1919

Copy link
Copy Markdown
Contributor

Fixes #11201

maybe_auto_title() claimed to generate titles only after the first exchange, but the guard was > 2 instead of >= 2, allowing auto-titling on the second exchange.

maybe_auto_title() claimed to generate titles only after the first
user-assistant exchange, but the guard was > 2 instead of >= 2,
allowing auto-titling on the second exchange.

Fixes NousResearch#11201
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint labels Apr 25, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #11313 — both fix the same off-by-one in maybe_auto_title() for #11201.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #11313

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for isolating the boundary condition.

Problems

  • Current main intentionally permits title generation during the first 1–2 exchanges: agent/title_generator.py:185-190 says “Be generous: generate on first 2 exchanges,” and the original feature commit e5fc916814e6937b2a9d4fa6baa8d3e42b6f79fb records that behavior explicitly. Changing the guard to >= 2 removes that fallback rather than fixing an accidental off-by-one.
  • The PR adds no boundary regression test; current coverage at tests/agent/test_title_generator.py:263-280 asserts skipping only after three user messages.

Suggested changes

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: maybe_auto_title still fires on the second exchange despite first-exchange contract

3 participants