Skip to content

fix(models): add glm-5.1 to opencode-go catalogs - #11269

Merged
teknium1 merged 1 commit into
NousResearch:mainfrom
helix4u:fix/opencode-go-glm51-catalog
Apr 16, 2026
Merged

fix(models): add glm-5.1 to opencode-go catalogs#11269
teknium1 merged 1 commit into
NousResearch:mainfrom
helix4u:fix/opencode-go-glm51-catalog

Conversation

@helix4u

@helix4u helix4u commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds glm-5.1 to Hermes's built-in OpenCode Go model catalogs.

OpenCode's current Go docs list glm-5.1 as a supported model on the same chat-completions endpoint as glm-5, but Hermes's hardcoded OpenCode Go lists were still only exposing glm-5 in the picker and setup defaults. This change brings those catalogs up to date.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Added glm-5.1 to the OpenCode Go provider list in hermes_cli/models.py
  • Added glm-5.1 to the OpenCode Go setup defaults in hermes_cli/setup.py
  • Extended OpenCode Go API-mode tests in tests/hermes_cli/test_model_validation.py
  • Updated the authenticated provider list expectation in tests/hermes_cli/test_opencode_go_in_model_list.py

How to Test

  1. Configure an OpenCode Go API key.
  2. Open the model picker or run setup with OpenCode Go.
  3. Confirm glm-5.1 appears alongside glm-5 in the available model list.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Ubuntu 24.04

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Targeted tests passed:

source venv/bin/activate && python -m pytest tests/hermes_cli/test_model_validation.py tests/hermes_cli/test_opencode_go_in_model_list.py -q

Result: 65 passed in 4.37s

Full suite run requested by maintainer:

source venv/bin/activate && python -m pytest tests/ -q -n 4

Result:

  • 37 failed
  • 12165 passed
  • 34 skipped

The failures were broad and not concentrated in the OpenCode Go catalog/model-validation area touched by this PR.

@helix4u
helix4u marked this pull request as ready for review April 16, 2026 23:31
@teknium1
teknium1 merged commit 6ba4bb6 into NousResearch:main Apr 16, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants