fix(honcho): reject whitespace-only honcho_search and honcho_reasoning queries - #11256
fix(honcho): reject whitespace-only honcho_search and honcho_reasoning queries#11256fjlaowan1983 wants to merge 1 commit into
Conversation
Strip query before validation; add regression tests (aligns upstream NousResearch#11192). Made-with: Cursor
|
Likely duplicate of #11192 — same fix: reject whitespace-only queries for honcho_search and honcho_reasoning. |
|
Thanks for the focused regression fix. The premise remains current: The change is scoped to the two required-query tools. The nearby Automated hermes-sweeper review. |
|
Merged via #66052 (rebase-merge) — your commit landed on main with your authorship preserved. The honcho_search half had been independently fixed by #62290; your honcho_reasoning whitespace guard and regression tests are now live. Thanks @fjlaowan1983! |
Summary
queryforhoncho_searchandhoncho_reasoningwith(args.get("query") or "").strip()before calling Honcho APIs.tool_errorshape as an emptyquery:Missing required parameter: query.tests/honcho_plugin/test_session.py(TestConcludeToolDispatch) asserting the backend methods are not invoked for whitespace-only input.Context
Related upstream discussion / radar: #11192 (
fix(honcho): reject whitespace-only tool queries).Test plan
python -m pytest tests/honcho_plugin/test_session.py::TestConcludeToolDispatch -v -o addopts=Noticed this while setting up uv on Windows WSL2 — trivial guard, but it avoids pointless Honcho calls when the model sends blank queries.