fix: wire Ollama Cloud into /model TUI picker (0 models regression) - #11066
Merged
Merged
Conversation
provider_model_ids() and list_authenticated_providers() had no case for "ollama-cloud", so the /model slash command showed 0 models despite fetch_ollama_cloud_models() being fully implemented. The CLI subcommand worked because it called fetch_ollama_cloud_models() directly. - Add ollama-cloud case to provider_model_ids() in models.py - Populate curated dict for ollama-cloud in list_authenticated_providers() - Add tests for both code paths
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #10964 by @jvcl. Fixes #10977 —
/modelTUI picker shows "Ollama Cloud (0 models)" becauseprovider_model_ids()andlist_authenticated_providers()had no case for"ollama-cloud".Based on #10964 by @jvcl — cherry-picked with authorship preserved.
Root cause
fetch_ollama_cloud_models()was implemented (PR #10782) but not wired into the two functions the/modelTUI picker depends on:provider_model_ids()inhermes_cli/models.pylist_authenticated_providers()inhermes_cli/model_switch.pyThe
hermes modelCLI subcommand worked fine because it callsfetch_ollama_cloud_models()directly.Changes
hermes_cli/models.py: Addollama-cloudcase toprovider_model_ids()— follows the same pattern as anthropic, copilot, nous, ai-gatewayhermes_cli/model_switch.py: Populatecurateddict forollama-cloudinlist_authenticated_providers()— follows the existing nous patterntests/hermes_cli/test_ollama_cloud_provider.py: Add 3 tests coveringprovider_model_ids(),list_authenticated_providers()model count, and negative (no creds) caseTest plan
provider_model_ids("ollama-cloud")returns models via models.dev fallback